use Carp::Clan qw/^DBIx::Class|^HTML::FormHandler|^Try::Tiny/;
use Scalar::Util qw( blessed );
use List::MoreUtils qw/ any /;
+use Try::Tiny;
sub recursive_update {
my %params = @_;
croak 'fixed fields needs to be an arrayref'
if defined $fixed_fields && ref $fixed_fields ne 'ARRAY';
+ # always warn about additional parameters if storage debugging is enabled
+ $unknown_params_ok = 0
+ if $source->storage->debug;
+
if ( blessed($updates) && $updates->isa('DBIx::Class::Row') ) {
return $updates;
}
- if ( exists $updates->{id} ) {
+
+ if ( !defined $object && exists $updates->{id} ) {
# warn "finding object by id " . $updates->{id} . "\n";
$object = $self->find( $updates->{id}, { key => 'primary' } );
my %fixed_fields = map { $_ => 1 } @$fixed_fields
if $fixed_fields;
+ # the updates hashref might contain the pk columns
+ # but with an undefined value
my @missing =
- grep { !exists $updates->{$_} && !exists $fixed_fields{$_} }
- $source->primary_columns;
- if ( !$object && !scalar @missing ) {
+ grep {
+ ( !exists $updates->{$_}
+ || ( exists $updates->{$_} && !defined $updates->{$_} ) )
+ && !exists $fixed_fields{$_}
+ } $source->primary_columns;
+
+ # warn "MISSING: " . join(', ', @missing) . "\n";
+ if ( !defined $object && scalar @missing == 0 ) {
# warn 'finding by: ' . Dumper( $updates ); use Data::Dumper;
$object = $self->find( $updates, { key => 'primary' } );
}
+
+ # add the resolved columns to the updates hashref
$updates = { %$updates, %$resolved };
- @missing =
- grep { !exists $resolved->{$_} } @missing;
- if ( !$object && !scalar @missing ) {
+ # the resolved hashref might contain the pk columns
+ # but with an undefined value
+ @missing = grep {
+ !exists $resolved->{$_}
+ || ( exists $resolved->{$_} && !defined $resolved->{$_} )
+ } @missing;
- # warn 'finding by +resolved: ' . Dumper( $updates ); use Data::Dumper;
+ #warn "MISSING2: " . join( ', ', @missing ) . "\n";
+ if ( !defined $object && scalar @missing == 0 ) {
+
+ # warn 'finding by +resolved: ' . Dumper( $updates ); use Data::Dumper;
$object = $self->find( $updates, { key => 'primary' } );
}
#warn "update m2m $name\n";
# TODO: only first pk col is used
my ($pk) = _get_pk_for_related( $self, $name );
- my @rows = ();
+ my @rows;
my $result_source = $object->$name->result_source;
my @updates;
if ( defined $value && ref $value eq 'ARRAY' ) {
elsif ( defined $value && !ref $value ) {
@updates = ($value);
}
- else {
- carp "value of many-to-many rel '$name' must be an arrayref or scalar";
+ elsif ( defined $value ) {
+ carp
+ "value of many-to-many rel '$name' must be an arrayref or scalar: $value";
}
for my $elem (@updates) {
if ( blessed($elem) && $elem->isa('DBIx::Class::Row') ) {
&& $DBIx::Class::ResultSource::UNRESOLVABLE_CONDITION
== $resolved;
+ #warn "RESOLVED: " . Dumper($resolved); use Data::Dumper;
+
my @rel_cols = keys %{ $info->{cond} };
map {s/^foreign\.//} @rel_cols;