oops missing a */

[chaz/openbox] / openbox / screen.c

diff --git a/openbox/screen.c b/openbox/screen.c
index d077c495e74b1f7c79b67f96ec028de4cc4ea228..f82275c0a66738e43c7eacafa39cb44d0756d8ab 100644 (file)
--- a/openbox/screen.c
+++ b/openbox/screen.c
@@ -2,7 +2,11 @@
 #include "prop.h"
 #include "screen.h"
 #include "client.h"
+#include "frame.h"
+#include "engine.h"
 #include "focus.h"
+#include "dispatch.h"
+#include "../render/render.h"
 
 #include <X11/Xlib.h>
 #ifdef HAVE_UNISTD_H
@@ -231,6 +235,8 @@ void screen_set_num_desktops(guint num)
     /* may be some unnamed desktops that we need to fill in with names */
     screen_update_desktop_names();
 
+    dispatch_ob(Event_Ob_NumDesktops);
+
     /* change our desktop if we're on one that no longer exists! */
     if (screen_desktop >= screen_num_desktops)
        screen_set_desktop(num - 1);
@@ -251,12 +257,21 @@ void screen_set_desktop(guint num)
 
     if (old == num) return;
 
-    for (it = stacking_list; it != NULL; it = it->next)
-       client_showhide(it->data, FALSE);
+    /* hide windows from bottom to top */
+    for (it = g_list_last(stacking_list); it != NULL; it = it->prev) {
+        Client *c = it->data;
+       if (c->frame->visible && !client_should_show(c))
+            engine_frame_hide(c->frame);
+    }
+
+    /* show windows from top to bottom */
+    for (it = stacking_list; it != NULL; it = it->next) {
+        Client *c = it->data;
+       if (!c->frame->visible && client_should_show(c))
+            engine_frame_show(c->frame);
+    }
 
-    /* force the callbacks to fire */
-    if (focus_client == NULL)
-       focus_set_client(NULL);
+    dispatch_ob(Event_Ob_Desktop);
 }
 
 void screen_update_layout()
@@ -356,15 +371,15 @@ void screen_show_desktop(gboolean show)
            Client *client = it->data;
            if (client->type == Type_Desktop)
                client_focus(client);
-           else
-               client_showhide(client, FALSE);
+           else if (client->frame->visible && !client_should_show(client))
+                engine_frame_hide(client->frame);
        }
     } else {
         /* top to bottom */
        for (it = stacking_list; it != NULL; it = it->next) {
            Client *client = it->data;
-           if (client->type != Type_Desktop)
-               client_showhide(client, FALSE);
+           if (!client->frame->visible && client_should_show(client))
+                engine_frame_show(client->frame);
        }
     }
 
@@ -379,18 +394,17 @@ void screen_show_desktop(gboolean show)
 
     show = show ? 1 : 0; /* make it boolean */
     PROP_SET32(ob_root, net_showing_desktop, cardinal, show);
+
+    dispatch_ob(Event_Ob_ShowDesktop);
 }
 
 void screen_install_colormap(Client *client, gboolean install)
 {
     if (client == NULL) {
-       /* XXX DONT USE THE DEFAULT SHIT HERE */
        if (install)
-           XInstallColormap(ob_display,
-                            DefaultColormap(ob_display, ob_screen));
+           XInstallColormap(ob_display, render_colormap);
        else
-           XUninstallColormap(ob_display,
-                              DefaultColormap(ob_display, ob_screen));
+           XUninstallColormap(ob_display, render_colormap);
     } else {
        XWindowAttributes wa;
        if (XGetWindowAttributes(ob_display, client->window, &wa)) {