make focus work without races.

[chaz/openbox] / otk / eventdispatcher.cc

diff --git a/otk/eventdispatcher.cc b/otk/eventdispatcher.cc
index 5be1c6b190aa77516c1c4b98b2d7f023c38e2798..6beff8dc3bcc2019590f0d07dd5f6e480482397a 100644 (file)
--- a/otk/eventdispatcher.cc
+++ b/otk/eventdispatcher.cc
@@ -11,7 +11,7 @@
 namespace otk {
 
 OtkEventDispatcher::OtkEventDispatcher()
-  : _fallback(0)
+  : _fallback(0), _master(0)
 {
 }
 
@@ -34,30 +34,128 @@ void OtkEventDispatcher::clearHandler(Window id)
   _map.erase(id);
 }
 
-#include <stdio.h>
 void OtkEventDispatcher::dispatchEvents(void)
 {
   XEvent e;
-  OtkEventHandler *handler;
-  OtkEventMap::iterator it;
 
   while (XPending(OBDisplay::display)) {
     XNextEvent(OBDisplay::display, &e);
 
-#ifdef DEBUG
+#if 0//defined(DEBUG)
     printf("Event %d window %lx\n", e.type, e.xany.window);
 #endif
 
-    it = _map.find(e.xany.window);
+    Window win;
+
+    // pick a window
+    switch (e.type) {
+    case UnmapNotify:
+      win = e.xunmap.window;
+      break;
+    case DestroyNotify:
+      win = e.xdestroywindow.window;
+      break;
+    case ConfigureRequest:
+      win = e.xconfigurerequest.window;
+      break;
+    default:
+      win = e.xany.window;
+    }
+    
+    // grab the lasttime and hack up the modifiers
+    switch (e.type) {
+    case ButtonPress:
+    case ButtonRelease:
+      _lasttime = e.xbutton.time;
+      e.xbutton.state &= ~(LockMask | OBDisplay::numLockMask() |
+                           OBDisplay::scrollLockMask());
+      break;
+    case KeyPress:
+      e.xkey.state &= ~(LockMask | OBDisplay::numLockMask() |
+                        OBDisplay::scrollLockMask());
+      break;
+    case MotionNotify:
+      _lasttime = e.xmotion.time;
+      e.xmotion.state &= ~(LockMask | OBDisplay::numLockMask() |
+                           OBDisplay::scrollLockMask());
+      break;
+    case PropertyNotify:
+      _lasttime = e.xproperty.time;
+      break;
+    case EnterNotify:
+    case LeaveNotify:
+      _lasttime = e.xcrossing.time;
+      break;
+    }
+
+    if (e.type == FocusIn || e.type == FocusOut)
+      // any other types are not ones we're interested in
+      if (e.xfocus.detail != NotifyNonlinear)
+        continue;
+
+    if (e.type == FocusOut) {
+      XEvent fi;
+      // send a FocusIn first if one exists
+      while (XCheckTypedEvent(OBDisplay::display, FocusIn, &fi)) {
+        // any other types are not ones we're interested in
+        printf("found focusin\n");
+        if (fi.xfocus.detail == NotifyNonlinear) {
+          printf("sending focusin\n");
+          dispatch(fi.xfocus.window, fi);
+          break;
+        }
+      }
+    }
+    
+    dispatch(win, e);
+  }
+}
+
+void OtkEventDispatcher::dispatch(Window win, const XEvent &e)
+{
+  OtkEventHandler *handler = 0;
+  OtkEventMap::iterator it;
 
-    if (it != _map.end())
-      handler = it->second;
-    else
-      handler = _fallback;
+  // master gets everything first
+  if (_master)
+    _master->handle(e);
 
-    if (handler)
-      handler->handle(e);
+  // find handler for the chosen window
+  it = _map.find(win);
+
+  if (it != _map.end()) {
+    // if we found a handler
+    handler = it->second;
+  } else if (e.type == ConfigureRequest) {
+    // unhandled configure requests must be used to configure the window
+    // directly
+    XWindowChanges xwc;
+      
+    xwc.x = e.xconfigurerequest.x;
+    xwc.y = e.xconfigurerequest.y;
+    xwc.width = e.xconfigurerequest.width;
+    xwc.height = e.xconfigurerequest.height;
+    xwc.border_width = e.xconfigurerequest.border_width;
+    xwc.sibling = e.xconfigurerequest.above;
+    xwc.stack_mode = e.xconfigurerequest.detail;
+      
+    XConfigureWindow(otk::OBDisplay::display, e.xconfigurerequest.window,
+                     e.xconfigurerequest.value_mask, &xwc);
+  } else {
+    // grab a falback if it exists
+    handler = _fallback;
   }
+
+  if (handler)
+    handler->handle(e);
+}
+
+OtkEventHandler *OtkEventDispatcher::findHandler(Window win)
+{
+  OtkEventMap::iterator it = _map.find(win);
+  if (it != _map.end())
+    return it->second;
+  return 0;
 }
 
 }