#define FLOOR(i) ((i) & (~0UL << FRACTION))
#define AVERAGE(a, b) (((((a) ^ (b)) & 0xfefefefeL) >> 1) + ((a) & (b)))
+void RrImagePicInit(RrImagePic *pic, gint w, gint h, RrPixel32 *data)
+{
+ gint i;
+
+ pic->width = w;
+ pic->height = h;
+ pic->data = data;
+ pic->sum = 0;
+ for (i = w*h; i > 0; --i)
+ pic->sum += *(data++);
+}
+
+static void RrImagePicFree(RrImagePic *pic)
+{
+ if (pic) {
+ g_free(pic->data);
+ g_free(pic);
+ }
+}
+
/*! Add a picture to an Image, that is, add another copy of the image at
another size. This may add it to the "originals" list or to the
"resized" list. */
g_hash_table_insert(self->cache->table, (*list)[0], self);
#ifdef DEBUG
- g_print("Adding %s picture to the cache: "
- "Image 0x%x, w %d h %d Hash %u\n",
+ g_debug("Adding %s picture to the cache:\n "
+ "Image 0x%x, w %d h %d Hash %u",
(*list == self->original ? "ORIGINAL" : "RESIZED"),
(guint)self, pic->width, pic->height, RrImagePicHash(pic));
#endif
gint j;
#ifdef DEBUG
- g_print("Removing %s picture from the cache: "
- "Image 0x%x, w %d h %d Hash %u\n",
+ g_debug("Removing %s picture from the cache:\n "
+ "Image 0x%x, w %d h %d Hash %u",
(*list == self->original ? "ORIGINAL" : "RESIZED"),
(guint)self, (*list)[i]->width, (*list)[i]->height,
RrImagePicHash((*list)[i]));
/* remove the picture as a key in the cache */
g_hash_table_remove(self->cache->table, (*list)[i]);
- /* free the picture (and its rgba data) */
- g_free((*list)[i]);
- g_free((*list)[i]->data);
+ /* free the picture */
+ RrImagePicFree((*list)[i]);
/* shift everything down one */
for (j = i; j < *len-1; ++j)
(*list)[j] = (*list)[j+1];
gulong srcW, gulong srcH,
gulong dstW, gulong dstH)
{
- RrPixel32 *dst;
+ RrPixel32 *dst, *dststart;
RrImagePic *pic;
gulong dstX, dstY, srcX, srcY;
gulong srcX1, srcX2, srcY1, srcY2;
gulong ratioX, ratioY;
gulong aspectW, aspectH;
+ /* XXX should these variables be ensured to not be zero in the callers? */
+ srcW = srcW ? srcW : 1;
+ srcH = srcH ? srcH : 1;
+ dstW = dstW ? dstW : 1;
+ dstH = dstH ? dstH : 1;
+
/* keep the aspect ratio */
aspectW = dstW;
aspectH = (gint)(dstW * ((gdouble)srcH / srcW));
aspectH = dstH;
aspectW = (gint)(dstH * ((gdouble)srcW / srcH));
}
- dstW = aspectW;
- dstH = aspectH;
+ dstW = aspectW ? aspectW : 1;
+ dstH = aspectH ? aspectH : 1;
if (srcW == dstW && srcH == dstH)
- return NULL; /* no scaling needed ! */
+ return NULL; /* no scaling needed! */
- pic = g_new(RrImagePic, 1);
- dst = g_new(RrPixel32, dstW * dstH);
- pic->width = dstW;
- pic->height = dstH;
- pic->data = dst;
+ dststart = dst = g_new(RrPixel32, dstW * dstH);
ratioX = (srcW << FRACTION) / dstW;
ratioY = (srcH << FRACTION) / dstH;
}
}
+ pic = g_new(RrImagePic, 1);
+ RrImagePicInit(pic, dstW, dstH, dststart);
+
return pic;
}
DrawRGBA(target, target_w, target_h,
scaled->data, scaled->width, scaled->height,
rgba->alpha, area);
+ RrImagePicFree(scaled);
}
else
DrawRGBA(target, target_w, target_h,
{
if (self && --self->ref == 0) {
#ifdef DEBUG
- g_print("Refcount to 0, removing ALL pictures from the cache: "
- "Image 0x%x\n", (guint)self);
+ g_debug("Refcount to 0, removing ALL pictures from the cache:\n "
+ "Image 0x%x", (guint)self);
#endif
while (self->n_original > 0)
RemovePicture(self, &self->original, 0, &self->n_original);
for (i = 0; i < self->n_original; ++i)
if (self->original[i]->width == w && self->original[i]->height == h) {
#ifdef DEBUG
- g_print("Found duplicate ORIGINAL image: "
- "Image 0x%x, w %d h %d\n", (guint)self, w, h);
+ g_debug("Found duplicate ORIGINAL image:\n "
+ "Image 0x%x, w %d h %d", (guint)self, w, h);
#endif
return;
}
/* add the new picture */
pic = g_new(RrImagePic, 1);
- pic->width = w;
- pic->height = h;
- pic->data = g_memdup(data, w*h*sizeof(RrPixel32));
+ RrImagePicInit(pic, w, h, g_memdup(data, w*h*sizeof(RrPixel32)));
AddPicture(self, &self->original, &self->n_original, pic);
}
gint i, min_diff, min_i, min_aspect_diff, min_aspect_i;
RrImage *self;
RrImagePic *pic;
+ gboolean free_pic;
self = img->image;
pic = NULL;
+ free_pic = FALSE;
/* is there an original of this size? (only w or h has to be right cuz
we maintain aspect ratios) */
if (self->cache->max_resized_saved)
/* add it to the top of the resized list */
AddPicture(self, &self->resized, &self->n_resized, pic);
+ else
+ free_pic = TRUE; /* don't leak mem! */
}
g_assert(pic != NULL);
DrawRGBA(target, target_w, target_h,
pic->data, pic->width, pic->height,
img->alpha, area);
+ if (free_pic)
+ RrImagePicFree(pic);
}