Added a runtime option for hiding the toolbar totally. Will be cleaner

[chaz/openbox] / src / openbox.cc

diff --git a/src/openbox.cc b/src/openbox.cc
index 55c07acd9272f535810fc20d124a8ed1923b0877..641235213bc865dedba9fb8665fab05de966444b 100644 (file)
--- a/src/openbox.cc
+++ b/src/openbox.cc
@@ -55,6 +55,7 @@
 #include "Window.h"
 #include "Workspace.h"
 #include "Workspacemenu.h"
+#include "Util.h"
 
 #include <string>
 #include <algorithm>
@@ -63,10 +64,13 @@
 #  include <stdio.h>
 #endif // HAVE_STDIO_H
 
-#ifdef    STDC_HEADERS
+#ifdef    HAVE_STDLIB_H
 #  include <stdlib.h>
+#endif // HAVE_STDLIB_H
+
+#ifdef    HAVE_STRING_H
 #  include <string.h>
-#endif // STDC_HEADERS
+#endif // HAVE_STRING_H
 
 #ifdef    HAVE_UNISTD_H
 #  include <sys/types.h>
@@ -205,7 +209,7 @@ Openbox::Openbox(int m_argc, char **m_argv, char *dpy_name, char *rc)
 
   screenList = new LinkedList<BScreen>;
   for (int i = 0; i < getNumberOfScreens(); i++) {
-    BScreen *screen = new BScreen(this, i);
+    BScreen *screen = new BScreen(*this, i);
 
     if (! screen->isScreenManaged()) {
       delete screen;
@@ -227,7 +231,7 @@ Openbox::Openbox(int m_argc, char **m_argv, char *dpy_name, char *rc)
 
   reconfigure_wait = reread_menu_wait = False;
 
-  timer = new BTimer(this, this);
+  timer = new BTimer(*this, *this);
   timer->setTimeout(0);
   timer->fireOnce(True);
 
@@ -336,14 +340,14 @@ void Openbox::process_event(XEvent *e) {
            if (my < 0) my = 0;
 
            if (mx + screen->getWorkspacemenu()->getWidth() >
-               screen->getWidth())
-             mx = screen->getWidth() -
+               screen->size().w())
+             mx = screen->size().w() -
                screen->getWorkspacemenu()->getWidth() -
                screen->getBorderWidth();
 
            if (my + screen->getWorkspacemenu()->getHeight() >
-               screen->getHeight())
-             my = screen->getHeight() -
+               screen->size().h())
+             my = screen->size().h() -
                screen->getWorkspacemenu()->getHeight() -
                screen->getBorderWidth();
 
@@ -362,13 +366,13 @@ void Openbox::process_event(XEvent *e) {
            if (mx < 0) mx = 0;
            if (my < 0) my = 0;
 
-           if (mx + screen->getRootmenu()->getWidth() > screen->getWidth())
-             mx = screen->getWidth() -
+           if (mx + screen->getRootmenu()->getWidth() > screen->size().w())
+             mx = screen->size().w() -
                screen->getRootmenu()->getWidth() -
                screen->getBorderWidth();
 
-           if (my + screen->getRootmenu()->getHeight() > screen->getHeight())
-               my = screen->getHeight() -
+           if (my + screen->getRootmenu()->getHeight() > screen->size().h())
+               my = screen->size().h() -
                  screen->getRootmenu()->getHeight() -
                  screen->getBorderWidth();
 
@@ -379,15 +383,16 @@ void Openbox::process_event(XEvent *e) {
              screen->getRootmenu()->show();
            }
           } else if (e->xbutton.button == 4) {
-            if ((screen->getCurrentWorkspaceID()-1)<0)
-              screen->changeWorkspaceID(screen->getWorkspaceCount()-1);
+            if ((screen->getCurrentWorkspaceID() + 1) >
+                screen->getWorkspaceCount() - 1)
+              screen->changeWorkspaceID(0);
             else
-              screen->changeWorkspaceID(screen->getCurrentWorkspaceID()-1);
+              screen->changeWorkspaceID(screen->getCurrentWorkspaceID() + 1);
           } else if (e->xbutton.button == 5) {
-            if ((screen->getCurrentWorkspaceID()+1)>screen->getWorkspaceCount()-1)
-              screen->changeWorkspaceID(0);
+            if ((screen->getCurrentWorkspaceID() - 1) < 0)
+              screen->changeWorkspaceID(screen->getWorkspaceCount() - 1);
             else
-              screen->changeWorkspaceID(screen->getCurrentWorkspaceID()+1);
+              screen->changeWorkspaceID(screen->getCurrentWorkspaceID() - 1);
           }
         }
       }
@@ -466,7 +471,7 @@ void Openbox::process_event(XEvent *e) {
     OpenboxWindow *win = searchWindow(e->xmaprequest.window);
 
     if (! win)
-      win = new OpenboxWindow(this, e->xmaprequest.window);
+      win = new OpenboxWindow(*this, e->xmaprequest.window);
 
     if ((win = searchWindow(e->xmaprequest.window)))
       win->mapRequestEvent(&e->xmaprequest);
@@ -1042,6 +1047,7 @@ void Openbox::save_rc(void) {
 
     switch (screen->getPlacementPolicy()) {
     case BScreen::CascadePlacement: placement = "CascadePlacement"; break;
+    case BScreen::BestFitPlacement: placement = "BestFitPlacement"; break;
     case BScreen::ColSmartPlacement: placement = "ColSmartPlacement"; break;
     default:
     case BScreen::RowSmartPlacement: placement = "RowSmartPlacement"; break;
@@ -1066,6 +1072,11 @@ void Openbox::save_rc(void) {
     config.setValue(rc_string, screen->getToolbar()->doAutoHide() ?
                     "True" : "False");
 
+    sprintf(rc_string, "session.screen%d.toolbar.hide", screen_number);
+    config.setValue(rc_string, screen->doToolbarHide() ?
+                    "True" : "False");
+
+
     switch (screen->getToolbarPlacement()) {
     case Toolbar::TopLeft: placement = "TopLeft"; break;
     case Toolbar::BottomLeft: placement = "BottomLeft"; break;
@@ -1207,9 +1218,9 @@ void Openbox::load_rc(void) {
 
 
 void Openbox::load_rc(BScreen *screen) {
-  assert (screen != NULL);
+  ASSERT (screen != NULL);
   const int screen_number = screen->getScreenNumber();
-  assert (screen_number >= 0);
+  ASSERT (screen_number >= 0);
 
   if (!config.load())
     return;
@@ -1322,6 +1333,13 @@ void Openbox::load_rc(BScreen *screen) {
   else
     screen->saveToolbarOnTop(False);
 
+  sprintf(name_lookup,  "session.screen%d.toolbar.hide", screen_number);
+  sprintf(class_lookup, "Session.Screen%d.Toolbar.Hide", screen_number);
+  if (config.getValue(name_lookup, class_lookup, b))
+    screen->saveToolbarHide((Bool)b);
+  else
+    screen->saveToolbarHide(False);
+
   sprintf(name_lookup,  "session.screen%d.toolbar.autoHide", screen_number);
   sprintf(class_lookup, "Session.Screen%d.Toolbar.autoHide", screen_number);
   if (config.getValue(name_lookup, class_lookup, b))
@@ -1332,7 +1350,6 @@ void Openbox::load_rc(BScreen *screen) {
   sprintf(name_lookup,  "session.screen%d.focusModel", screen_number);
   sprintf(class_lookup, "Session.Screen%d.FocusModel", screen_number);
   if (config.getValue(name_lookup, class_lookup, s)) {
-    cout << s << endl;
     if (0 == strncasecmp(s.c_str(), "clicktofocus", s.length())) {
       screen->saveAutoRaise(False);
       screen->saveSloppyFocus(False);
@@ -1363,6 +1380,8 @@ void Openbox::load_rc(BScreen *screen) {
       screen->savePlacementPolicy(BScreen::RowSmartPlacement);
     else if (0 == strncasecmp(s.c_str(), "ColSmartPlacement", s.length()))
       screen->savePlacementPolicy(BScreen::ColSmartPlacement);
+    else if (0 == strncasecmp(s.c_str(), "BestFitPlacement", s.length()))
+      screen->savePlacementPolicy(BScreen::BestFitPlacement);
     else
       screen->savePlacementPolicy(BScreen::CascadePlacement);
   } else