X-Git-Url: https://git.brokenzipper.com/gitweb?a=blobdiff_plain;f=openbox%2Ffocus.c;h=b473686aea5a49b970e76dc303436c0502a41cd5;hb=aae4f66f68b32c8ad2760eeb12ebb9cb3d44602a;hp=5d9e0fe4a294078ceed942bdc7bcddc207dc7278;hpb=82b2f0aa7a1723632e8d3cf7dc772e4bdb66868a;p=chaz%2Fopenbox

diff --git a/openbox/focus.c b/openbox/focus.c
index 5d9e0fe4..b473686a 100644
--- a/openbox/focus.c
+++ b/openbox/focus.c
@@ -224,7 +224,7 @@ ObClient* focus_fallback_target(gboolean allow_refocus, ObClient *old)
     }
 
 
-    ob_debug_type(OB_DEBUG_FOCUS, "trying  the focus order\n");
+    ob_debug_type(OB_DEBUG_FOCUS, "trying the focus order\n");
     for (it = focus_order; it; it = g_list_next(it))
         if (allow_refocus || it->data != old) {
             ObClient *c = it->data;
@@ -295,7 +295,6 @@ static gchar *popup_get_name(ObClient *c, ObClient **nametarget)
     /* find our highest direct parent, including non-normal windows */
     for (p = c; p->transient_for && p->transient_for != OB_TRAN_GROUP;
          p = p->transient_for);
-    if (nametarget) *nametarget = p;
 
     if (c->desktop != DESKTOP_ALL && c->desktop != screen_desktop)
         desk = screen_desktop_names[c->desktop];
@@ -315,6 +314,8 @@ static gchar *popup_get_name(ObClient *c, ObClient **nametarget)
     }
     g_free(title);
 
+    /* set this only if we're returning true and they asked for it */
+    if (ret && nametarget) *nametarget = p;
     return ret;
 }
 
@@ -361,13 +362,15 @@ static void popup_cycle(ObClient *c, gboolean show,
         /* make it null terminated so we can use g_strfreev */
         names = g_new(char*, n+1);
         for (it = targets, i = 0; it; it = g_list_next(it), ++i) {
-            ObClient *ft = it->data;
-            names[i] = popup_get_name(ft, &showtarget);
+            ObClient *ft = it->data, *t;
+            names[i] = popup_get_name(ft, &t);
 
-            /* little optimization.. save this text so we dont have to get it
-               again */
-            if (ft == c)
+            /* little optimization.. save this text and client, so we dont
+               have to get it again */
+            if (ft == c) {
                 showtext = g_strdup(names[i]);
+                showtarget = t;
+            }
         }
         names[n] = NULL;
 
@@ -553,16 +556,15 @@ static gboolean valid_focus_target(ObClient *ft,
                      /* let alt-tab go to these windows when a window in its
                         group already has focus ... */
                      ((focus_client && ft->group == focus_client->group) ||
-                      /* ... or if there are no application windows in its
-                         group */
-                      !client_has_application_group_siblings(ft))));
+                      /* ... or if there are no main windows in its group */
+                      !client_has_non_helper_group_siblings(ft))));
 
     /* it's not set to skip the taskbar (unless it is a type that would be
        expected to set this hint */
-    ok = ok && (!(ft->type == OB_CLIENT_TYPE_DOCK ||
-                  ft->type == OB_CLIENT_TYPE_TOOLBAR ||
-                  ft->type == OB_CLIENT_TYPE_MENU ||
-                  ft->type == OB_CLIENT_TYPE_UTILITY) ||
+    ok = ok && ((ft->type == OB_CLIENT_TYPE_DOCK ||
+                 ft->type == OB_CLIENT_TYPE_TOOLBAR ||
+                 ft->type == OB_CLIENT_TYPE_MENU ||
+                 ft->type == OB_CLIENT_TYPE_UTILITY) ||
                 !ft->skip_taskbar);
 
     /* it's not going to just send fous off somewhere else (modal window) */