X-Git-Url: https://git.brokenzipper.com/gitweb?a=blobdiff_plain;f=openbox%2Ffocus.c;h=b6d294bbd076096e107df463e908a02469cb0144;hb=8aee387193fd73bbe4a8019bc7e31d5d0e18e83d;hp=1006c72557b8d9e1db9d9ad09594cf60419f665d;hpb=2d1b5d6e0a46cd8d3c89dec7662e28106dee0b88;p=chaz%2Fopenbox diff --git a/openbox/focus.c b/openbox/focus.c index 1006c725..b6d294bb 100644 --- a/openbox/focus.c +++ b/openbox/focus.c @@ -179,10 +179,6 @@ void focus_fallback(ObFocusFallbackType type) */ focus_set_client(NULL); - if (!config_focus_last && config_focus_follow) - if (focus_under_pointer()) - return; - if (type == OB_FOCUS_FALLBACK_UNFOCUSING && old) { /* try for transient relations */ if (old->transient_for) { @@ -201,6 +197,10 @@ void focus_fallback(ObFocusFallbackType type) } } + if (!config_focus_last && config_focus_follow) + if (focus_under_pointer()) + return; + #if 0 /* try for group relations */ if (old->group) { @@ -221,12 +221,7 @@ void focus_fallback(ObFocusFallbackType type) for (it = focus_order[screen_desktop]; it != NULL; it = it->next) if (type != OB_FOCUS_FALLBACK_UNFOCUSING || it->data != old) - if (client_normal(it->data) && - /* dont fall back to 'anonymous' fullscreen windows. theres no - checks for this is in transient/group fallbacks, so they can - be fallback targets there. */ - !((ObClient*)it->data)->fullscreen && - client_can_focus(it->data)) { + if (client_normal(it->data) && client_can_focus(it->data)) { gboolean r = client_focus(it->data); assert(r); return; @@ -281,7 +276,7 @@ static gboolean valid_focus_target(ObClient *ft) focus an iconic window, but we want to be able to, so we just check if the focus flags on the window allow it, and its on the current desktop */ - return (ft->transients == NULL && client_normal(ft) && + return (ft == client_focus_target(ft) && client_normal(ft) && ((ft->can_focus || ft->focus_notify) && !ft->skip_taskbar && (ft->desktop == screen_desktop || ft->desktop == DESKTOP_ALL))); @@ -294,7 +289,7 @@ void focus_cycle(gboolean forward, gboolean linear, static ObClient *t = NULL; static GList *order = NULL; GList *it, *start, *list; - ObClient *ft; + ObClient *ft = NULL; if (cancel) { if (focus_cycle_target) @@ -329,7 +324,6 @@ void focus_cycle(gboolean forward, gboolean linear, it = it->prev; if (it == NULL) it = g_list_last(list); } - /*ft = client_focus_target(it->data);*/ ft = it->data; if (valid_focus_target(ft)) { if (ft != focus_cycle_target) { /* prevents flicker */