X-Git-Url: https://git.brokenzipper.com/gitweb?a=blobdiff_plain;f=otk%2Fwidget.cc;h=551a7900b181b22a825d08dcbb8f63c0e73a22d9;hb=23940f9e034af023af610c56e915a6044ea436ec;hp=604992fd1f1fbaf48de13a7651e8b56a5b1fef12;hpb=8f8acc24933830d4f5784616b9b0c5896bde0b93;p=chaz%2Fopenbox

diff --git a/otk/widget.cc b/otk/widget.cc
index 604992fd..551a7900 100644
--- a/otk/widget.cc
+++ b/otk/widget.cc
@@ -23,8 +23,9 @@ Widget::Widget(Widget *parent, Direction direction)
     _visible(false), _grabbed_mouse(false),
     _grabbed_keyboard(false), _stretchable_vert(false),
     _stretchable_horz(false), _texture(0), _bg_pixmap(0), _bg_pixel(0),
-    _bcolor(0), _bwidth(0), _screen(parent->screen()), _fixed_width(false),
-    _fixed_height(false), _event_dispatcher(parent->eventDispatcher())
+    _bcolor(0), _bwidth(0), _pos(0,0), _screen(parent->screen()),
+    _fixed_width(false), _fixed_height(false),
+    _event_dispatcher(parent->eventDispatcher())
 {
   assert(parent);
   parent->addChild(this);
@@ -42,7 +43,7 @@ Widget::Widget(EventDispatcher *event_dispatcher, Style *style,
     _bevel_width(bevel_width), _ignore_config(0), _visible(false),
     _grabbed_mouse(false), _grabbed_keyboard(false),
     _stretchable_vert(false), _stretchable_horz(false), _texture(0),
-    _bg_pixmap(0), _bg_pixel(0), _bcolor(0), _bwidth(0),
+    _bg_pixmap(0), _bg_pixel(0), _bcolor(0), _bwidth(0), _pos(0,0),
     _screen(style->getScreen()), _fixed_width(false), _fixed_height(false),
     _event_dispatcher(event_dispatcher)
 {
@@ -65,16 +66,14 @@ Widget::~Widget()
   if (_parent)
     _parent->removeChild(this);
 
-  XDestroyWindow(Display::display, _window);
+  XDestroyWindow(**display, _window);
 }
 
 void Widget::create(bool override_redirect)
 {
-  const ScreenInfo *scr_info = Display::screenInfo(_screen);
+  const ScreenInfo *scr_info = display->screenInfo(_screen);
   Window p_window = _parent ? _parent->window() : scr_info->rootWindow();
 
-  _rect.setRect(0, 0, 1, 1); // just some initial values
-
   XSetWindowAttributes attrib_create;
   unsigned long create_mask = CWBackPixmap | CWBorderPixel | CWEventMask;
 
@@ -93,8 +92,8 @@ void Widget::create(bool override_redirect)
     attrib_create.cursor = _cursor;
   }
 
-  _window = XCreateWindow(Display::display, p_window, _rect.x(),
-                          _rect.y(), _rect.width(), _rect.height(), 0,
+  _window = XCreateWindow(**display, p_window, _pos.x(),
+                          _pos.y(), width(), height(), 0,
                           scr_info->depth(), InputOutput,
                           scr_info->visual(), create_mask, &attrib_create);
   _ignore_config++;
@@ -104,14 +103,14 @@ void Widget::setWidth(int w)
 {
   assert(w > 0);
   _fixed_width = true;  
-  setGeometry(_rect.x(), _rect.y(), w, _rect.height());
+  setGeometry(_pos.x(), _pos.y(), w, height());
 }
 
 void Widget::setHeight(int h)
 {
   assert(h > 0);
   _fixed_height = true;
-  setGeometry(_rect.x(), _rect.y(), _rect.width(), h);
+  setGeometry(_pos.x(), _pos.y(), _pos.x(), h);
 }
 
 void Widget::move(const Point &to)
@@ -121,8 +120,8 @@ void Widget::move(const Point &to)
 
 void Widget::move(int x, int y)
 {
-  _rect.setPos(x, y);
-  XMoveWindow(Display::display, _window, x, y);
+  _pos.setPoint(x, y);
+  XMoveWindow(**display, _window, x, y);
   _ignore_config++;
 }
 
@@ -135,7 +134,7 @@ void Widget::resize(int w, int h)
 {
   assert(w > 0 && h > 0);
   _fixed_width = _fixed_height = true;
-  setGeometry(_rect.x(), _rect.y(), w, h);
+  setGeometry(_pos.x(), _pos.y(), w, h);
 }
 
 void Widget::setGeometry(const Rect &new_geom)
@@ -150,11 +149,15 @@ void Widget::setGeometry(const Point &topleft, int width, int height)
 
 void Widget::setGeometry(int x, int y, int width, int height)
 {
-  _rect = Rect(x, y, width, height);
+  _pos.setPoint(x, y);
+  setSize(width, height);
   _dirty = true;
 
-  XMoveResizeWindow(Display::display, _window, x, y, width, height);
-  _ignore_config++;
+  // don't use an XMoveResizeWindow here, because it doesn't seem to move
+  // windows with StaticGravity? This works, that didn't.
+  XResizeWindow(**display, _window, width, height);
+  XMoveWindow(**display, _window, x, y);
+  _ignore_config+=2;
 }
 
 void Widget::show(bool recursive)
@@ -172,7 +175,7 @@ void Widget::show(bool recursive)
       (*it)->show();
   }
 
-  XMapWindow(Display::display, _window);
+  XMapWindow(**display, _window);
   _visible = true;
 }
 
@@ -187,7 +190,7 @@ void Widget::hide(bool recursive)
       (*it)->hide();
   }
   
-  XUnmapWindow(Display::display, _window);
+  XUnmapWindow(**display, _window);
   _visible = false;
 }
 
@@ -213,7 +216,7 @@ void Widget::unfocus(void)
 
 bool Widget::grabMouse(void)
 {
-  Status ret = XGrabPointer(Display::display, _window, True,
+  Status ret = XGrabPointer(**display, _window, True,
                             (ButtonPressMask | ButtonReleaseMask |
                              ButtonMotionMask | EnterWindowMask |
                              LeaveWindowMask | PointerMotionMask),
@@ -228,13 +231,13 @@ void Widget::ungrabMouse(void)
   if (! _grabbed_mouse)
     return;
 
-  XUngrabPointer(Display::display, CurrentTime);
+  XUngrabPointer(**display, CurrentTime);
   _grabbed_mouse = false;
 }
 
 bool Widget::grabKeyboard(void)
 {
-  Status ret = XGrabKeyboard(Display::display, _window, True,
+  Status ret = XGrabKeyboard(**display, _window, True,
                              GrabModeSync, GrabModeAsync, CurrentTime);
   _grabbed_keyboard = (ret == GrabSuccess);
   return _grabbed_keyboard;
@@ -246,7 +249,7 @@ void Widget::ungrabKeyboard(void)
   if (! _grabbed_keyboard)
     return;
 
-  XUngrabKeyboard(Display::display, CurrentTime);
+  XUngrabKeyboard(**display, CurrentTime);
   _grabbed_keyboard = false;
 }
 
@@ -254,16 +257,16 @@ void Widget::render(void)
 {
   if (!_texture) return;
 
-  _bg_pixmap = _texture->render(_rect.width(), _rect.height(), _bg_pixmap);
+  _bg_pixmap = _texture->render(width(), height(), _bg_pixmap);
 
   if (_bg_pixmap) {
-    XSetWindowBackgroundPixmap(Display::display, _window, _bg_pixmap);
+    XSetWindowBackgroundPixmap(**display, _window, _bg_pixmap);
     _bg_pixel = None;
   } else {
     unsigned int pix = _texture->color().pixel();
     if (pix != _bg_pixel) {
       _bg_pixel = pix;
-      XSetWindowBackground(Display::display, _window, pix);
+      XSetWindowBackground(**display, _window, pix);
     }
   }
 }
@@ -291,22 +294,22 @@ void Widget::adjustHorz(void)
   for (it = _children.begin(); it != end; ++it) {
     tmp = *it;
     if (tmp->isStretchableVert())
-      tmp->setHeight(_rect.height() > _bevel_width * 2 ?
-                     _rect.height() - _bevel_width * 2 : _bevel_width);
+      tmp->setHeight(height() > _bevel_width * 2 ?
+                     height() - _bevel_width * 2 : _bevel_width);
     if (tmp->isStretchableHorz())
       stretchable.push_back(tmp);
     else
-      width += tmp->_rect.width() + _bevel_width;
+      width += tmp->width() + _bevel_width;
 
-    if (tmp->_rect.height() > tallest)
-      tallest = tmp->_rect.height();
+    if (tmp->height() > tallest)
+      tallest = tmp->height();
   }
 
   if (stretchable.size() > 0) {
     WidgetList::iterator str_it = stretchable.begin(),
       str_end = stretchable.end();
 
-    int str_width = _rect.width() - width / stretchable.size();
+    int str_width = Surface::width() - width / stretchable.size();
 
     for (; str_it != str_end; ++str_it)
       (*str_it)->setWidth(str_width > _bevel_width ? str_width - _bevel_width
@@ -320,10 +323,10 @@ void Widget::adjustHorz(void)
     int x, y;
 
     if (prev_widget)
-      x = prev_widget->_rect.x() + prev_widget->_rect.width() + _bevel_width;
+      x = prev_widget->_pos.x() + prev_widget->width() + _bevel_width;
     else
-      x = _rect.x() + _bevel_width;
-    y = (tallest - tmp->_rect.height()) / 2 + _bevel_width;
+      x = _pos.x() + _bevel_width;
+    y = (tallest - tmp->height()) / 2 + _bevel_width;
 
     tmp->move(x, y);
 
@@ -348,22 +351,22 @@ void Widget::adjustVert(void)
   for (it = _children.begin(); it != end; ++it) {
     tmp = *it;
     if (tmp->isStretchableHorz())
-      tmp->setWidth(_rect.width() > _bevel_width * 2 ?
-                    _rect.width() - _bevel_width * 2 : _bevel_width);
+      tmp->setWidth(width() > _bevel_width * 2 ?
+                    width() - _bevel_width * 2 : _bevel_width);
     if (tmp->isStretchableVert())
       stretchable.push_back(tmp);
     else
-      height += tmp->_rect.height() + _bevel_width;
+      height += tmp->height() + _bevel_width;
 
-    if (tmp->_rect.width() > widest)
-      widest = tmp->_rect.width();
+    if (tmp->width() > widest)
+      widest = tmp->width();
   }
 
   if (stretchable.size() > 0) {
     WidgetList::iterator str_it = stretchable.begin(),
       str_end = stretchable.end();
 
-    int str_height = _rect.height() - height / stretchable.size();
+    int str_height = Surface::height() - height / stretchable.size();
 
     for (; str_it != str_end; ++str_it)
       (*str_it)->setHeight(str_height > _bevel_width ?
@@ -377,10 +380,10 @@ void Widget::adjustVert(void)
     int x, y;
 
     if (prev_widget)
-      y = prev_widget->_rect.y() + prev_widget->_rect.height() + _bevel_width;
+      y = prev_widget->_pos.y() + prev_widget->height() + _bevel_width;
     else
-      y = _rect.y() + _bevel_width;
-    x = (widest - tmp->_rect.width()) / 2 + _bevel_width;
+      y = _pos.y() + _bevel_width;
+    x = (widest - tmp->width()) / 2 + _bevel_width;
 
     tmp->move(x, y);
 
@@ -395,7 +398,7 @@ void Widget::update(void)
   if (_dirty) {
     adjust();
     render();
-    XClearWindow(Display::display, _window);
+    XClearWindow(**display, _window);
   }
 
   WidgetList::iterator it = _children.begin(), end = _children.end();
@@ -412,9 +415,9 @@ void Widget::internalResize(int w, int h)
   if (! _fixed_width && ! _fixed_height)
     resize(w, h);
   else if (! _fixed_width)
-    resize(w, _rect.height());
+    resize(w, height());
   else if (! _fixed_height)
-    resize(_rect.width(), h);
+    resize(width(), h);
 }
 
 void Widget::addChild(Widget *child, bool front)
@@ -472,9 +475,10 @@ void Widget::configureHandler(const XConfigureEvent &e)
   if (_ignore_config) {
     _ignore_config--;
   } else {
-    if (!(e.width == _rect.width() && e.height == _rect.height())) {
+    if (!(e.width == width() && e.height == height())) {
       _dirty = true;
-      _rect.setSize(e.width, e.height);
+      _pos.setPoint(e.x, e.y);
+      setSize(e.width, e.height);
     }
     update();
   }