X-Git-Url: https://git.brokenzipper.com/gitweb?a=blobdiff_plain;f=scripts%2Fhistoryplacement.py;h=cb9fb96cc77877b4528b012722ef008659708193;hb=feaf3ac4e5847d27e3747b09e7443915afa97b0b;hp=6ce5dff54f8622f2c94307e6accb48729c38e96a;hpb=7b8c5c892a642553cd375f8180eff25c7406b865;p=chaz%2Fopenbox

diff --git a/scripts/historyplacement.py b/scripts/historyplacement.py
index 6ce5dff5..cb9fb96c 100644
--- a/scripts/historyplacement.py
+++ b/scripts/historyplacement.py
@@ -3,34 +3,63 @@
 ### to the ob.EventAction.PlaceWindow event to use it.                     ###
 ##############################################################################
 
-import windowplacement # fallback routines
-
-##############################################################################
-###       Options for the historyplacement module (Options in the          ###
-###                windowplacement module also apply!)                     ###
-##############################################################################
-IGNORE_REQUESTED_POSITIONS = 0
-"""When true, the placement algorithm will attempt to place windows even
-   when they request a position (like XMMS). Note this only applies to
-   normal windows, not to special cases like desktops and docks."""
-FALLBACK = windowplacement.random
-"""The window placement algorithm that will be used when history placement
-   does not have a place for the window."""
-CONFIRM_CALLBACK = 0
-"""Set this to a function to have the function called before attempting to
-   place a window via history. If the function returns a non-zero, then an
-   attempt will be made to place the window. If it returns zero, the
-   fallback method will be directly applied instead."""
-FILENAME = 'historydb'
-"""The name of the file where history data will be stored. The number of
-   the screen is appended onto this filename."""
-##############################################################################
+import windowplacement, config
 
 def place(data):
     """Place a window usingthe history placement algorithm."""
     _place(data)
 
-###########################################################################
+export_functions = place
+
+##############################################################################
+
+config.add('historyplacement',
+           'ignore_requested_positions',
+           'Ignore Requested Positions',
+           "When true, the placement algorithm will attempt to place " + \
+           "windows even when they request a position (like XMMS can)." + \
+           "Note this only applies to 'normal' windows, not to special " + \
+           "cases like desktops and docks.",
+           'boolean',
+           0)
+config.add('historyplacement',
+           'dont_duplicate',
+           "Don't Diplicate",
+           "When true, if 2 copies of the same match in history are to be " + \
+           "placed before one of them is closed (so it would be placed " + \
+           "over-top of the last one), this will cause the second window to "+\
+           "not be placed via history, and the 'Fallback Algorithm' will be "+\
+           "used instead.",
+           'boolean',
+           1)
+config.add('historyplacement',
+           'filename',
+           'History Database Filename',
+           "The name of the file where history data will be stored. The " + \
+           "number of the screen is appended onto this name. The file will " +\
+           "be placed in ~/.openbox/.",
+           'string',
+           'historydb')
+config.add('historyplacement',
+           'fallback',
+           'Fallback Algorithm',
+           "The window placement algorithm that will be used when history " + \
+           "placement does not have a place for the window.",
+           'enum',
+           windowplacement.random,
+           options = windowplacement.export_functions)
+config.add('historyplacement',
+           'confirm_callback',
+           'Confirm Placement Callback',
+           "A function which will be called before attempting to place a " + \
+           "window via history. If the function returns true, then an " + \
+           "attempt will be made to place the window. If it returns false, " +\
+           "the 'Fallback Algorithm' will be directly applied instead. The " +\
+           "function must take 1 argument, which will be the callback data " +\
+           "which was passed to invoke the window placement.",
+           'function',
+           None)
+
 ###########################################################################
 
 ###########################################################################
@@ -51,6 +80,7 @@ class _state:
         self.role = role
         self.x = x
         self.y = y
+        self.placed = 0
     def __eq__(self, other):
         if self.appname == other.appname and \
            self.appclass == other.appclass and \
@@ -61,8 +91,9 @@ class _state:
 def _load(data):
     global _data
     try:
-        file = open(os.environ['HOME'] + '/.openbox/' + FILENAME+"." +
-                    str(data.screen), 'r')
+        file = open(os.environ['HOME'] + '/.openbox/' + \
+                    config.get('historyplacement', 'filename') + \
+                    "." + str(data.screen), 'r')
         # read data
         for line in file.readlines():
             line = line[:-1] # drop the '\n'
@@ -82,8 +113,9 @@ def _load(data):
 
 def _save(data):
     global _data
-    file = open(os.environ['HOME']+'/.openbox/'+FILENAME+"."+str(data.screen),
-                'w')
+    file = open(os.environ['HOME']+'/.openbox/'+ \
+                config.get('historyplacement', 'filename') + \
+                "." + str(data.screen), 'w')
     if file:
         while len(_data)-1 < data.screen:
             _data.append([])
@@ -115,11 +147,13 @@ def _find(screen, state):
 def _place(data):
     global _data
     if data.client:
-        if not (IGNORE_REQUESTED_POSITIONS and data.client.normal()):
+        if not (config.get('historyplacement', 'ignore_requested_positions') \
+                and data.client.normal()):
             if data.client.positionRequested(): return
         state = _create_state(data)
         try:
-            if not CONFIRM_CALLBACK or CONFIRM_CALLBACK(data):
+            confirm = config.get('historyplacement', 'confirm_callback')
+            if not confirm or confirm(data):
                 print "looking for : " + state.appname +  " : " + \
                       state.appclass + " : " + state.role
 
@@ -128,13 +162,19 @@ def _place(data):
                     coords = _data[data.screen][i]
                     print "Found in history ("+str(coords.x)+","+\
                           str(coords.y)+")"
-                    data.client.move(coords.x, coords.y)
-                    return
+                    if not (config.get('historyplacement', 'dont_duplicate') \
+                            and coords.placed):
+                        data.client.move(coords.x, coords.y)
+                        coords.placed = 1
+                        return
+                    else:
+                        print "Already placed another window there"
                 else:
                     print "No match in history"
         except TypeError:
             pass
-    if FALLBACK: FALLBACK(data)
+    fallback = config.get('historyplacement', 'fallback')
+    if fallback: fallback(data)
 
 def _save_window(data):
     global _data