X-Git-Url: https://git.brokenzipper.com/gitweb?a=blobdiff_plain;f=src%2Fbindings.cc;h=2ce8c8e4304a4e01fa5b56d9a028997cbca56b53;hb=bb303c74047b7d4f13b54170e1d24fbe5662e9f9;hp=253e13837585b5c7cde99e4f024e811d95067719;hpb=9e77a88d269bfafb78e56a646bfacebdd6ff4c5a;p=chaz%2Fopenbox diff --git a/src/bindings.cc b/src/bindings.cc index 253e1383..2ce8c8e4 100644 --- a/src/bindings.cc +++ b/src/bindings.cc @@ -19,6 +19,8 @@ extern "C" { #define _(str) gettext(str) } +#include + namespace ob { static bool buttonvalue(const std::string &button, unsigned int *val) @@ -98,7 +100,7 @@ bool Bindings::translate(const std::string &str, Binding &b,bool askey) const printf(_("Invalid Key name in key binding: %s\n"), key.c_str()); return false; } - if (!(b.key = XKeysymToKeycode(otk::Display::display, sym))) + if (!(b.key = XKeysymToKeycode(**otk::display, sym))) printf(_("No valid keycode for Key in key binding: %s\n"), key.c_str()); return b.key != 0; } else { @@ -145,17 +147,17 @@ KeyBindingTree *Bindings::buildtree(const StringVect &keylist, Bindings::Bindings() : _curpos(&_keytree), _resetkey(0,0), - _timer(openbox->timerManager(), - (otk::TimeoutHandler)resetChains, this) + _timer((otk::Timer *) 0) { - _timer.setTimeout(5000); // chains reset after 5 seconds - // setResetKey("C-g"); // set the default reset key } Bindings::~Bindings() { + if (_timer) + delete _timer; + grabKeys(false); removeAllKeys(); // removeAllButtons(); XXX @@ -244,14 +246,14 @@ bool Bindings::addKey(const StringVect &keylist, PyObject *callback) destroytree(tree); } else { // grab the server here to make sure no key pressed go missed - otk::Display::grab(); + otk::display->grab(); grabKeys(false); // assimilate this built tree into the main tree assimilate(tree); // assimilation destroys/uses the tree grabKeys(true); - otk::Display::ungrab(); + otk::display->ungrab(); } Py_INCREF(callback); @@ -277,7 +279,7 @@ bool Bindings::removeKey(const StringVect &keylist, PyObject *callback) callback); if (it != t->callbacks.end()) { // grab the server here to make sure no key pressed go missed - otk::Display::grab(); + otk::display->grab(); grabKeys(false); _curpos = &_keytree; @@ -286,7 +288,7 @@ bool Bindings::removeKey(const StringVect &keylist, PyObject *callback) Py_XDECREF(*it); grabKeys(true); - otk::Display::ungrab(); + otk::display->ungrab(); return true; } @@ -300,12 +302,12 @@ void Bindings::setResetKey(const std::string &key) Binding b(0, 0); if (translate(key, b)) { // grab the server here to make sure no key pressed go missed - otk::Display::grab(); + otk::display->grab(); grabKeys(false); _resetkey.key = b.key; _resetkey.modifiers = b.modifiers; grabKeys(true); - otk::Display::ungrab(); + otk::display->ungrab(); } } @@ -342,28 +344,28 @@ void Bindings::removeAllKeys() void Bindings::grabKeys(bool grab) { for (int i = 0; i < openbox->screenCount(); ++i) { - Window root = otk::Display::screenInfo(i)->rootWindow(); + Window root = otk::display->screenInfo(i)->rootWindow(); KeyBindingTree *p = _curpos->first_child; while (p) { if (grab) { - otk::Display::grabKey(p->binding.key, p->binding.modifiers, + otk::display->grabKey(p->binding.key, p->binding.modifiers, root, false, GrabModeAsync, GrabModeAsync, false); } else - otk::Display::ungrabKey(p->binding.key, p->binding.modifiers, + otk::display->ungrabKey(p->binding.key, p->binding.modifiers, root); p = p->next_sibling; } if (_resetkey.key) if (grab) - otk::Display::grabKey(_resetkey.key, _resetkey.modifiers, + otk::display->grabKey(_resetkey.key, _resetkey.modifiers, root, false, GrabModeAsync, GrabModeAsync, false); else - otk::Display::ungrabKey(_resetkey.key, _resetkey.modifiers, + otk::display->ungrabKey(_resetkey.key, _resetkey.modifiers, root); } } @@ -379,13 +381,17 @@ void Bindings::fireKey(int screen, unsigned int modifiers, unsigned int key, while (p) { if (p->binding.key == key && p->binding.modifiers == modifiers) { if (p->chain) { - _timer.start(); // start/restart the timer + if (_timer) + delete _timer; + _timer = new otk::Timer(5000, // 5 second timeout + (otk::Timer::TimeoutHandler)resetChains, + this); // grab the server here to make sure no key pressed go missed - otk::Display::grab(); + otk::display->grab(); grabKeys(false); _curpos = p; grabKeys(true); - otk::Display::ungrab(); + otk::display->ungrab(); } else { Client *c = openbox->focusedClient(); KeyData data(screen, c, time, modifiers, key); @@ -403,13 +409,16 @@ void Bindings::fireKey(int screen, unsigned int modifiers, unsigned int key, void Bindings::resetChains(Bindings *self) { - self->_timer.stop(); + if (self->_timer) { + delete self->_timer; + self->_timer = (otk::Timer *) 0; + } // grab the server here to make sure no key pressed go missed - otk::Display::grab(); + otk::display->grab(); self->grabKeys(false); self->_curpos = &self->_keytree; self->grabKeys(true); - otk::Display::ungrab(); + otk::display->ungrab(); } @@ -500,10 +509,10 @@ void Bindings::grabButton(bool grab, const Binding &b, MouseContext context, return; } if (grab) - otk::Display::grabButton(b.key, b.modifiers, win, false, mask, mode, - GrabModeAsync, None, None, false); + otk::display->grabButton(b.key, b.modifiers, win, false, mask, mode, + GrabModeAsync, None, None, false); else - otk::Display::ungrabButton(b.key, b.modifiers, win); + otk::display->ungrabButton(b.key, b.modifiers, win); } void Bindings::grabButtons(bool grab, Client *client) @@ -519,7 +528,7 @@ void Bindings::fireButton(MouseData *data) { if (data->context == MC_Window) { // Replay the event, so it goes to the client, and ungrab the device. - XAllowEvents(otk::Display::display, ReplayPointer, data->time); + XAllowEvents(**otk::display, ReplayPointer, data->time); } ButtonBindingList::iterator it, end = _buttons[data->context].end(); @@ -541,7 +550,7 @@ bool Bindings::addEvent(EventAction action, PyObject *callback) } #ifdef XKB if (action == EventBell && _eventlist[action].empty()) - XkbSelectEvents(otk::Display::display, XkbUseCoreKbd, + XkbSelectEvents(**otk::display, XkbUseCoreKbd, XkbBellNotifyMask, XkbBellNotifyMask); #endif // XKB _eventlist[action].push_back(callback); @@ -563,7 +572,7 @@ bool Bindings::removeEvent(EventAction action, PyObject *callback) _eventlist[action].erase(it); #ifdef XKB if (action == EventBell && _eventlist[action].empty()) - XkbSelectEvents(otk::Display::display, XkbUseCoreKbd, + XkbSelectEvents(**otk::display, XkbUseCoreKbd, XkbBellNotifyMask, 0); #endif // XKB return true;