X-Git-Url: https://git.brokenzipper.com/gitweb?a=blobdiff_plain;f=src%2Fxheader.c;h=1f1b190d0cc5eca9b47fb3c57b8c9f138e619b81;hb=91b2d65e9dccae981f308a659d6c7bdd32285598;hp=6f8c140b12cdd229b8551ca26a4386893f906534;hpb=10edb315da532371e65a7d83a16f50ade5b545e4;p=chaz%2Ftar

diff --git a/src/xheader.c b/src/xheader.c
index 6f8c140..1f1b190 100644
--- a/src/xheader.c
+++ b/src/xheader.c
@@ -51,6 +51,9 @@ locate_handler (char const *keyword)
   return NULL;
 }
 
+/* Decodes a single extended header record. Advances P to the next
+   record.
+   Returns true on success, false otherwise. */
 static bool
 decode_record (char **p, struct tar_stat_info *st)
 {
@@ -61,13 +64,13 @@ decode_record (char **p, struct tar_stat_info *st)
   struct xhdr_tab const *t;
 
   if (**p == 0)
-    return true;
+    return false;
 
   len = strtoul (*p, p, 10);
   if (**p != ' ')
     {
-      ERROR ((0, 0, _("Malformed extended header")));
-      return true;
+      ERROR ((0, 0, _("Malformed extended header: missing whitespace after the length")));
+      return false;
     }
 
   keyword = ++*p;
@@ -77,8 +80,8 @@ decode_record (char **p, struct tar_stat_info *st)
 
   if (**p != '=')
     {
-      ERROR ((0, 0, _("Malformed extended header")));
-      return true;
+      ERROR ((0, 0, _("Malformed extended header: missing equal sign")));
+      return false;
     }
 
   eqp = *p;
@@ -98,17 +101,17 @@ decode_record (char **p, struct tar_stat_info *st)
     }
   *eqp = '=';
   *p = &start[len];
-  return false;
+  return true;
 }
 
 void
 xheader_decode (struct tar_stat_info *st)
 {
-  char *p = extended_header.buffer;
+  char *p = extended_header.buffer + BLOCKSIZE;
   char *endp = &extended_header.buffer[extended_header.size-1];
 
   while (p < endp)
-    if (decode_record (&p, st))
+    if (!decode_record (&p, st))
       break;
 }
 
@@ -133,29 +136,31 @@ xheader_store (char const *keyword, struct tar_stat_info const *st)
 void
 xheader_read (union block *p, size_t size)
 {
-  size_t i, j;
+  size_t j = 0;
   size_t nblocks;
 
   free (extended_header.buffer);
+  size += BLOCKSIZE;
   extended_header.size = size;
   nblocks = (size + BLOCKSIZE - 1) / BLOCKSIZE;
   extended_header.buffer = xmalloc (size + 1);
 
-  set_next_block_after (p);
-  for (i = j = 0; i < nblocks; i++)
+  do
     {
-      size_t len;
+      size_t len = size;
 
-      p = find_next_block ();
-      len = size;
       if (len > BLOCKSIZE)
 	len = BLOCKSIZE;
+      
       memcpy (&extended_header.buffer[j], p->buffer, len);
       set_next_block_after (p);
 
+      p = find_next_block ();
+
       j += len;
       size -= len;
     }
+  while (size > 0);
 }
 
 static size_t