]> Dogcows Code - chaz/openbox/commitdiff
Fix use after free in error message
authorMikael Magnusson <mikachu@gmail.com>
Sun, 11 Aug 2013 10:02:30 +0000 (12:02 +0200)
committerMikael Magnusson <mikachu@gmail.com>
Sun, 11 Aug 2013 10:04:13 +0000 (12:04 +0200)
obrender/image.c

index 0164a8c8c3a5df8e42809e30999ea08e0d4107cb..8ff9bf106b0ef204b339a77527dafcc613934ea8 100644 (file)
@@ -652,10 +652,9 @@ RrImage* RrImageNewFromName(RrImageCache *cache, const gchar *name)
     }
 #endif
 
-    g_free(path);
-
     if (!loaded) {
         g_message("Cannot load image \"%s\" from file \"%s\"", name, path);
+        g_free(path);
 #if defined(USE_LIBRSVG)
         DestroyRsvgLoader(rsvg_loader);
 #endif
@@ -665,6 +664,8 @@ RrImage* RrImageNewFromName(RrImageCache *cache, const gchar *name)
         return NULL;
     }
 
+    g_free(path);
+
     /* get an RrImage that contains an RrImageSet with this picture in it.
        the RrImage might be new, or reused if the picture was already in the
        cache.
This page took 0.028317 seconds and 4 git commands to generate.