From: Sergey Poznyakoff <gray@gnu.org.ua>
Date: Fri, 9 Dec 2005 10:04:52 +0000 (+0000)
Subject: (to_chars_subst): Remove unused variable
X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=273810a9f73a71bc8417a09a9a9c4c569df0fa11;p=chaz%2Ftar

(to_chars_subst): Remove unused variable
Make sure useful result code is returned.
---

diff --git a/src/create.c b/src/create.c
index 7955e6b..e1af8db 100644
--- a/src/create.c
+++ b/src/create.c
@@ -128,7 +128,6 @@ to_chars_subst (int negative, int gnu_format, uintmax_t value, size_t valsize,
   char const *minval_string;
   char const *maxval_string = STRINGIFY_BIGINT (maxval, maxbuf);
   char const *value_string;
-  char *p;
     
   if (gnu_format)
     {
@@ -163,11 +162,12 @@ to_chars_subst (int negative, int gnu_format, uintmax_t value, size_t valsize,
       WARN ((0, 0, _("value %s out of %s range %s..%s; substituting %s"),
 	     value_string, type, minval_string, maxval_string,
 	     sub_string));
-      to_chars (negsub, s, valsize, 0, where, size, type);
+      return to_chars (negsub, s, valsize, 0, where, size, type);
     }
   else
     ERROR ((0, 0, _("value %s out of %s range %s..%s"),
 	    value_string, type, minval_string, maxval_string));
+  return false;
 }
 
 /* Convert NEGATIVE VALUE (which was originally of size VALSIZE) to