From: Dana Jansens <danakj@orodu.net>
Date: Wed, 23 May 2007 17:34:09 +0000 (+0000)
Subject: i remembered why i remvoed the fake enter events from press type actions moving windo... 
X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=48314dc246bfc86c8272bca5f2784ca5ccfa3aa5;p=chaz%2Fopenbox

i remembered why i remvoed the fake enter events from press type actions moving windows around. it makes for focus events with notifywhilegrab. remove it and make a comment explaining why.
---

diff --git a/openbox/action.c b/openbox/action.c
index f1066979..85d84798 100644
--- a/openbox/action.c
+++ b/openbox/action.c
@@ -47,18 +47,17 @@ static void client_action_end(union ActionData *data)
 {
     if (config_focus_follow)
         if (data->any.context != OB_FRAME_CONTEXT_CLIENT) {
-            if (!data->any.button && data->any.c) {
+            if (!data->any.button && data->any.c)
                 event_ignore_all_queued_enters();
-            } else {
-                ObClient *c;
-
-                /* usually this is sorta redundant, but with a press action
-                   that moves windows our from under the cursor, the enter
-                   event will come as a GrabNotify which is ignored, so this
-                   makes a fake enter event
-                */
-                if ((c = client_under_pointer()))
-                    event_enter_client(c);
+            else {
+                /* we USED to create a fake enter event here, so that when you
+                   used a Press context, and the button was still down,
+                   you could still get enter events that weren't
+                   NotifyWhileGrabbed.
+
+                   only problem with this is that then the resulting focus
+                   change events can ALSO be NotifyWhileGrabbed. And that is
+                   bad. So, don't create fake enter events anymore. */
             }
         }
 }