From: Dana Jansens <danakj@orodu.net>
Date: Sat, 10 Mar 2007 20:52:04 +0000 (+0000)
Subject: no longer honor transient_for = None or Root. it violates the ICCCM and is causing... 
X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=49dd40d99ff2f55f3932d191b2e71faf5055a363;p=chaz%2Fopenbox

no longer honor transient_for = None or Root. it violates the ICCCM and is causing problems. there are proper ways to make group transient windows with the EWMH.
---

diff --git a/openbox/client.c b/openbox/client.c
index 732f031f..c70d6591 100644
--- a/openbox/client.c
+++ b/openbox/client.c
@@ -1036,7 +1036,13 @@ void client_update_transient_for(ObClient *self)
                    a dockapp, for example */
                 target = NULL;
             }
-            
+
+#if 0 
+/* we used to do this, but it violates the ICCCM and causes problems because
+   toolkits seem to set transient_for = root rather arbitrarily (eg kicker's
+   config dialogs), so it is being removed. the ewmh provides other ways to
+   make things transient for their group. -dana
+*/
             if (!target && self->group) {
                 /* not transient to a client, see if it is transient for a
                    group */
@@ -1048,6 +1054,8 @@ void client_update_transient_for(ObClient *self)
                     target = OB_TRAN_GROUP;
                 }
             }
+#endif
+
         }
     } else if (self->type == OB_CLIENT_TYPE_DIALOG && self->group) {
         self->transient = TRUE;