From: Dana Jansens <danakj@orodu.net>
Date: Thu, 20 Mar 2003 22:44:14 +0000 (+0000)
Subject: kill all enter events on a desktop switch
X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=4f427471b862f2f547981878b1d088ac52929936;p=chaz%2Fopenbox

kill all enter events on a desktop switch
---

diff --git a/plugins/focus.c b/plugins/focus.c
index 43f0ae8e..a00a0e93 100644
--- a/plugins/focus.c
+++ b/plugins/focus.c
@@ -46,18 +46,25 @@ static void focus_fallback(gboolean switching_desks)
                 XEvent e;
                 Client *c = it->data;
 
-                /* skip the next enter event from the desktop switch so focus
+                /* XXX... not anymore
+                   skip the next enter event from the desktop switch so focus
                    doesn't skip briefly to what was under the pointer */
-                if (XCheckTypedEvent(ob_display, EnterNotify, &e)) {
-                    XPutBackEvent(ob_display, &e);
+
+                /* kill all enter events from prior to the desktop switch, we
+                   aren't interested in them if we have found our own target
+                   to focus.
+                   XXX this is rude to other plugins...can this be done
+                   better? count the events in the queue? */
+                while (XCheckTypedEvent(ob_display, EnterNotify, &e));
+/*                    XPutBackEvent(ob_display, &e);
+                    g_message("skip");
                     ++skip_enter;
-                }
+                    }*/
 
                 /* I have to do this warp twice! Otherwise windows dont get
                    Enter/Leave events when i warp on a desktop switch! */
                 XWarpPointer(ob_display, None, c->window, 0, 0, 0, 0,
                              c->area.width / 2, c->area.height / 2);
-                ++skip_enter;
                 XWarpPointer(ob_display, None, c->window, 0, 0, 0, 0,
                              c->area.width / 2, c->area.height / 2);
             }
@@ -93,10 +100,17 @@ static void events(ObEvent *e, void *foo)
         break;
 
     case Event_X_EnterNotify:
-        if (skip_enter)
+        if (skip_enter) {
+            if (e->data.x.client != NULL)
+                g_message("skipped enter %lx", e->data.x.client->window);
+            else
+                g_message("skipped enter 'root'");
             --skip_enter;
-        else if (e->data.x.client && client_normal(e->data.x.client))
+        }
+        else if (e->data.x.client != NULL && client_normal(e->data.x.client)) {
+            g_message("enter %lx", e->data.x.client->window);
             client_focus(e->data.x.client);
+        }
         break;
 
     default: