From: Sergey Poznyakoff <gray@gnu.org.ua>
Date: Sat, 18 Dec 2004 20:07:04 +0000 (+0000)
Subject: (decode_options): Ignore --seek if used with --delete.
X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=90b1e244870201e90a168f744f6af1fe9c41f0b6;p=chaz%2Ftar

(decode_options): Ignore --seek if used with --delete.
Delete.c is based on the assumption that the archive is being
actually read, not lseeked.
---

diff --git a/src/tar.c b/src/tar.c
index 56a8e73..31d7d30 100644
--- a/src/tar.c
+++ b/src/tar.c
@@ -1464,6 +1464,18 @@ decode_options (int argc, char **argv)
 			  _("--occurrence cannot be used in the requested operation mode")));
     }
 
+  if (seekable_archive && subcommand_option == DELETE_SUBCOMMAND)
+    {
+      /* The current code in delete.c is based on the assumption that
+	 skip_member() reads all data from the archive. So, we should
+	 make sure it won't use seeks. On the other hand, the same code
+	 depends on the ability to backspace a record in the archive,
+	 so setting seekable_archive to false is technically incorrect.
+         However, it is tested only in skip_member(), so it's not a
+	 problem. */
+      seekable_archive = false;
+    }
+  
   if (archive_names == 0)
     {
       /* If no archive file name given, try TAPE from the environment, or