From: Sergey Poznyakoff Date: Fri, 20 Feb 2004 11:45:15 +0000 (+0000) Subject: Added a comment X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=b4e605a82978e85056ba046b5d71c34d43887a4e;p=chaz%2Ftar Added a comment --- diff --git a/src/create.c b/src/create.c index 01324d3..7884755 100644 --- a/src/create.c +++ b/src/create.c @@ -186,6 +186,8 @@ to_chars (int negative, uintmax_t value, size_t valsize, { int negsub; uintmax_t sub = substitute (&negsub) & maxval; + /* FIXME: This is the only place where GNU_FORMAT differs from + OLDGNU_FORMAT. Apart from this they are completely identical. */ uintmax_t s = (negsub &= archive_format == GNU_FORMAT) ? - sub : sub; char subbuf[UINTMAX_STRSIZE_BOUND + 1]; char *sub_string = STRINGIFY_BIGINT (s, subbuf + 1); diff --git a/src/tar.h b/src/tar.h index 25b65b1..677d1dd 100644 --- a/src/tar.h +++ b/src/tar.h @@ -253,7 +253,9 @@ enum archive_format USTAR_FORMAT, /* POSIX.1-1988 (ustar) format */ POSIX_FORMAT, /* POSIX.1-2001 format */ STAR_FORMAT, /* Star format defined in 1994 */ - GNU_FORMAT /* POSIX format with GNU extensions */ + GNU_FORMAT /* Same as OLDGNU_FORMAT with one exception: + see FIXME note for to_chars() function + (create.c:189) */ }; /* Information about a sparse file. */