From: Mikael Magnusson <mikachu@gmail.com>
Date: Mon, 10 Nov 2008 22:25:23 +0000 (+0100)
Subject: Another problem pointed out by clang
X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=bd2db36b6cbbc04614e0444fbf652f0a24f8f3ac;p=chaz%2Fopenbox

Another problem pointed out by clang

Using format specifiers without arguments in printf is still bad.

openbox/debug.c:105:18: warning: format string is not a string literal (potentially insecure)
    fprintf(out, log_domain);
                 ^~~~~~~~~~
openbox/debug.c:107:18: warning: format string is not a string literal (potentially insecure)
    fprintf(out, level);
                 ^~~~~
openbox/debug.c:109:18: warning: format string is not a string literal (potentially insecure)
    fprintf(out, message);
                 ^~~~~~~
---

diff --git a/openbox/debug.c b/openbox/debug.c
index 6b92c9ec..db18784c 100644
--- a/openbox/debug.c
+++ b/openbox/debug.c
@@ -102,11 +102,11 @@ void ob_debug_enable(ObDebugType type, gboolean enable)
 static inline void log_print(FILE *out, const gchar* log_domain,
                              const gchar *level, const gchar *message)
 {
-    fprintf(out, log_domain);
+    fprintf(out, "%s", log_domain);
     fprintf(out, "-");
-    fprintf(out, level);
+    fprintf(out, "%s", level);
     fprintf(out, ": ");
-    fprintf(out, message);
+    fprintf(out, "%s", message);
     fprintf(out, "\n");
     fflush(out);
 }