From: Mikael Magnusson <mikachu@comhem.se>
Date: Thu, 8 Jun 2006 11:05:29 +0000 (+0000)
Subject: some notes to self
X-Git-Url: https://git.brokenzipper.com/gitweb?a=commitdiff_plain;h=f80ab241f31676d8ae5377d62986ee793dc27ca7;p=chaz%2Fopenbox

some notes to self
---

diff --git a/openbox/client.c b/openbox/client.c
index 0cc393ba..e7af04b8 100644
--- a/openbox/client.c
+++ b/openbox/client.c
@@ -295,6 +295,7 @@ void client_manage(Window window)
     client_apply_startup_state(self);
 
     /* get and set application level settings */
+    /* XXX move that function here */
     settings = (ObAppSetting *) get_client_settings(self);
 
     if (settings) {
@@ -361,10 +362,11 @@ void client_manage(Window window)
         gint x = self->area.x, ox = x;
         gint y = self->area.y, oy = y;
 
-        place_client(self, &x, &y);
-
         if (settings)
+            /* XXX put this in place.c */
             place_window_from_settings(settings, self, &x, &y);
+        else
+            place_client(self, &x, &y);
 
         /* make sure the window is visible. */
         client_find_onscreen(self, &x, &y,
diff --git a/openbox/per_app_settings.c b/openbox/per_app_settings.c
index c8ab4ed5..73331cc6 100644
--- a/openbox/per_app_settings.c
+++ b/openbox/per_app_settings.c
@@ -20,6 +20,9 @@
 #include "screen.h"
 #include "config.h"
 
+/* XXX put in client.c */
+/* This should possibly do something more interesting than just match
+ * against WM_CLASS literally. */
 ObAppSetting *get_client_settings(ObClient *client)
 {
     GSList *a = config_per_app_settings;
@@ -38,6 +41,7 @@ ObAppSetting *get_client_settings(ObClient *client)
     return NULL;
 }
 
+/* XXX put in place.c */
 void place_window_from_settings(ObAppSetting *setting, ObClient *client, gint *x, gint *y)
 {
     gint px, py, i;