From 54e4a0df6506b2a8c60f28c42bc1a02093a3c026 Mon Sep 17 00:00:00 2001 From: Sergey Poznyakoff Date: Mon, 9 Aug 2004 11:25:15 +0000 Subject: [PATCH] Rearranged leading comments. Added explicit references to original report messages wherever available. --- tests/append.sh | 5 ++--- tests/delete01.sh | 5 ++--- tests/delete02.sh | 5 ++--- tests/delete03.sh | 2 -- tests/delete04.sh | 5 ++--- tests/extrac01.sh | 5 ++--- tests/extrac02.sh | 5 ++--- tests/extrac03.sh | 5 ++--- tests/extrac04.sh | 5 ++--- tests/gzip.sh | 5 ++--- tests/ignfail.sh | 5 ++--- tests/incremen.sh | 5 ++--- tests/link01.sh | 11 +++++++---- tests/listed01.sh | 9 +++++---- tests/longv7.sh | 6 +++--- tests/multiv01.sh | 5 ++--- tests/multiv02.sh | 14 ++++++++------ tests/old.sh | 5 ++--- tests/options.sh | 5 ++--- tests/recurse.sh | 1 - tests/same-order01.sh | 9 +++++---- tests/same-order02.sh | 9 ++++----- tests/sparse01.sh | 5 ++--- tests/version.sh | 5 ++--- tests/volume.sh | 5 ++--- 25 files changed, 66 insertions(+), 80 deletions(-) diff --git a/tests/append.sh b/tests/append.sh index ecc805f..d3adcca 100755 --- a/tests/append.sh +++ b/tests/append.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Append was just not working. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Problem: Append was just not working. + . ./preset . $srcdir/before diff --git a/tests/delete01.sh b/tests/delete01.sh index 2149c63..e620d90 100755 --- a/tests/delete01.sh +++ b/tests/delete01.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Deleting a member after a big one was destroying the archive. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Deleting a member after a big one was destroying the archive. + . ./preset . $srcdir/before diff --git a/tests/delete02.sh b/tests/delete02.sh index 60f20ed..2a1df38 100755 --- a/tests/delete02.sh +++ b/tests/delete02.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Deleting a member with the archive from stdin was not working correctly. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Deleting a member with the archive from stdin was not working correctly. + . ./preset . $srcdir/before diff --git a/tests/delete03.sh b/tests/delete03.sh index 0683b71..cf988e6 100755 --- a/tests/delete03.sh +++ b/tests/delete03.sh @@ -1,6 +1,4 @@ #! /bin/sh -# Deleting members with long file names. - # Copyright (C) 2001 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify diff --git a/tests/delete04.sh b/tests/delete04.sh index 005466e..47090a6 100755 --- a/tests/delete04.sh +++ b/tests/delete04.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Deleting a large last member was destroying earlier members. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Deleting a large last member was destroying earlier members. + . ./preset . $srcdir/before diff --git a/tests/extrac01.sh b/tests/extrac01.sh index dd3be09..f16e922 100755 --- a/tests/extrac01.sh +++ b/tests/extrac01.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# There was a diagnostic when directory already exists. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# There was a diagnostic when directory already exists. + . ./preset . $srcdir/before diff --git a/tests/extrac02.sh b/tests/extrac02.sh index 5c0b69e..083abea 100755 --- a/tests/extrac02.sh +++ b/tests/extrac02.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Could not extract symlinks over an existing file. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Could not extract symlinks over an existing file. + . ./preset . $srcdir/before diff --git a/tests/extrac03.sh b/tests/extrac03.sh index e223094..94ae69e 100755 --- a/tests/extrac03.sh +++ b/tests/extrac03.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Paths going up and down were inducing extraction loops. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Paths going up and down were inducing extraction loops. + . ./preset . $srcdir/before diff --git a/tests/extrac04.sh b/tests/extrac04.sh index ea1fe75..4b588b3 100755 --- a/tests/extrac04.sh +++ b/tests/extrac04.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Check for fnmatch problems in glibc 2.1.95. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Check for fnmatch problems in glibc 2.1.95. + . ./preset . $srcdir/before diff --git a/tests/gzip.sh b/tests/gzip.sh index 68ce48d..06ee173 100755 --- a/tests/gzip.sh +++ b/tests/gzip.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# tar should detect that its gzip child failed. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# tar should detect that its gzip child failed. + . ./preset TAR_ARCHIVE_FORMATS=auto . $srcdir/before diff --git a/tests/ignfail.sh b/tests/ignfail.sh index 17b4f9b..ec0fb10 100755 --- a/tests/ignfail.sh +++ b/tests/ignfail.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Unreadable directories yielded error despite --ignore-failed-read. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Unreadable directories yielded error despite --ignore-failed-read. + . ./preset . $srcdir/before diff --git a/tests/incremen.sh b/tests/incremen.sh index 7e05da6..efb0edb 100755 --- a/tests/incremen.sh +++ b/tests/incremen.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# A directory older than the listed entry was skipped completely. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# A directory older than the listed entry was skipped completely. + . ./preset TAR_ARCHIVE_FORMATS="gnu oldgnu" . $srcdir/before diff --git a/tests/link01.sh b/tests/link01.sh index 06aa74b..f88d4dd 100755 --- a/tests/link01.sh +++ b/tests/link01.sh @@ -17,14 +17,17 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. -# If a member with link count > 2 was stored in the archive twice, +# Problem: If a member with link count > 2 was stored in the archive twice, # previous versions of tar were not able to extract it, since they # were trying to link the file to itself, which always failed and # lead to removing the already extracted copy. This script tests # the workaround by Paul Eggert that leaves the extracted copy # untouched. - -# The script is based on the report by Toby Peterson +# +# Reported by: Toby Peterson +# +# References: <2330D503-D20A-11D8-A0CF-00039391EECE@apple.com> +# http://lists.gnu.org/archive/html/bug-tar/2004-07/msg00009.html . ./preset . $srcdir/before @@ -48,4 +51,4 @@ out="test.txt . $srcdir/after -# End of link01.sh \ No newline at end of file +# End of link01.sh diff --git a/tests/listed01.sh b/tests/listed01.sh index df01898..029369e 100755 --- a/tests/listed01.sh +++ b/tests/listed01.sh @@ -1,8 +1,4 @@ #! /bin/sh - -# Check if listed-incremental backups work for individual files. -# Script proposed by Andreas Schuldei - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -21,6 +17,11 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Check if listed-incremental backups work for individual files. +# Script proposed by Andreas Schuldei +# References: <20040215014223.GA9699@lukas.schuldei.com> +# http://lists.gnu.org/archive/html/bug-tar/2004-02/msg00011.html + . ./preset TAR_ARCHIVE_FORMATS="gnu oldgnu" . $srcdir/before diff --git a/tests/longv7.sh b/tests/longv7.sh index 28fe6aa..6f0bb68 100755 --- a/tests/longv7.sh +++ b/tests/longv7.sh @@ -1,7 +1,4 @@ #! /bin/sh -# Old format (V7) archives should not accept file names longer than -# 99 characters - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,9 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Old format (V7) archives should not accept file names longer than +# 99 characters + . ./preset TAR_ARCHIVE_FORMATS="v7" . $srcdir/before diff --git a/tests/multiv01.sh b/tests/multiv01.sh index 8b29728..58678e9 100755 --- a/tests/multiv01.sh +++ b/tests/multiv01.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Test multivolume dumps from pipes. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Test multivolume dumps from pipes. + . ./preset TAR_ARCHIVE_FORMATS="gnu oldgnu" . $srcdir/before diff --git a/tests/multiv02.sh b/tests/multiv02.sh index 324b066..2b21b45 100755 --- a/tests/multiv02.sh +++ b/tests/multiv02.sh @@ -1,9 +1,4 @@ #! /bin/sh - -# Previous versions of tar were not able to skip a member straddling -# the multivolume archive boundary. Reported by Mads Martin Joergensen -# - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -22,6 +17,13 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Previous versions of tar were not able to skip a member straddling +# the multivolume archive boundary. Reported by Mads Martin Joergensen +# +# +# References: <20040402144254.GC4409@suse.de> +# http://lists.gnu.org/archive/html/bug-tar/2004-04/msg00002.html + . ./preset TAR_ARCHIVE_FORMATS="gnu oldgnu" . $srcdir/before @@ -40,4 +42,4 @@ separator en " -. $srcdir/after \ No newline at end of file +. $srcdir/after diff --git a/tests/old.sh b/tests/old.sh index f488847..2ce64a6 100755 --- a/tests/old.sh +++ b/tests/old.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# An old archive was not receiving directories. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# An old archive was not receiving directories. + . ./preset TAR_ARCHIVE_FORMATS=auto . $srcdir/before diff --git a/tests/options.sh b/tests/options.sh index 15f9216..20c3629 100755 --- a/tests/options.sh +++ b/tests/options.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Ensure that TAR_OPTIONS works in conjunction with old-style options. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Ensure that TAR_OPTIONS works in conjunction with old-style options. + . ./preset TAR_ARCHIVE_FORMATS=auto . $srcdir/before diff --git a/tests/recurse.sh b/tests/recurse.sh index 9a450a4..79404d6 100755 --- a/tests/recurse.sh +++ b/tests/recurse.sh @@ -1,5 +1,4 @@ #! /bin/sh - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # diff --git a/tests/same-order01.sh b/tests/same-order01.sh index 8b8680b..a4dbe5c 100755 --- a/tests/same-order01.sh +++ b/tests/same-order01.sh @@ -1,8 +1,4 @@ #! /bin/sh - -# -C dir did not work with --same-order -# Bug reported by Karl-Michael Schneider - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -21,6 +17,11 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Problem: -C dir did not work with --same-order +# Reported by: Karl-Michael Schneider +# References: <20040507122613.GB12457@pike.phil.uni-passau.de> +# http://lists.gnu.org/archive/html/bug-tar/2004-05/msg00008.html + . ./preset . $srcdir/before diff --git a/tests/same-order02.sh b/tests/same-order02.sh index 80770c5..c5cac7b 100755 --- a/tests/same-order02.sh +++ b/tests/same-order02.sh @@ -1,9 +1,4 @@ #! /bin/sh - -# In previous versions a single -C option did not work with --same-order -# (see same-order01.sh). However, multiple -C options worked OK. -# Test if we did not break the correct behavior. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -22,6 +17,10 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# In previous versions a single -C option did not work with --same-order +# (see same-order01.sh). However, multiple -C options worked OK. +# Test if we did not break the correct behavior. + . ./preset . $srcdir/before diff --git a/tests/sparse01.sh b/tests/sparse01.sh index 05f7cc6..f49eaa7 100755 --- a/tests/sparse01.sh +++ b/tests/sparse01.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Check sparse file handling. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Check sparse file handling. + . ./preset TAR_ARCHIVE_FORMATS="gnu oldgnu posix" . $srcdir/before diff --git a/tests/version.sh b/tests/version.sh index c9c8674..f24c943 100755 --- a/tests/version.sh +++ b/tests/version.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Check if the proper version is being tested. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Check if the proper version is being tested. + . ./preset if test -n "`$PACKAGE --version | sed -n s/$PACKAGE.*$VERSION/OK/p`"; then diff --git a/tests/volume.sh b/tests/volume.sh index caa0dc9..3b17940 100755 --- a/tests/volume.sh +++ b/tests/volume.sh @@ -1,7 +1,4 @@ #! /bin/sh - -# Volume labels are checked on read by fnmatch. - # This file is part of GNU tar testsuite. # Copyright (C) 2004 Free Software Foundation, Inc. # @@ -20,6 +17,8 @@ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. +# Volume labels are checked on read by fnmatch. + . ./preset TAR_ARCHIVE_FORMATS="gnu oldgnu" . $srcdir/before -- 2.45.2